build(weekly): Enable complete debug symbols for VC6 weekly builds #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm no CI expert, so don't know how to validate the workflow changes locally. |
xezon
approved these changes
Nov 5, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Looks good. Merge now or need to wait until after Minidump?
xezon
added
Build
Author
It does not have to wait for minidump, even though it will probably see the most benefit of it. So either order is fine, whichever is the easiest. |
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables full debug information for the weekly builds.
As weekly builds are used by more people, having matching and usable PDBs available for debugging issues is desirable, especially when #1594 is merged. Full debug info is more or less required for debugging crashes, but the PDBs created by the current regular vc6 builds have limited usability due to not enabling it for speed reasons.
This change creates a new CMake preset called
vc6-weekly, which differs from the regularvc6preset in enabling the featureVc6FullDebug(RTS_BUILD_OPTION_VC6_FULL_DEBUG). Compile time does go up, but as weekly releases only occur once per week and developers can still use the speedyvc6preset it seems like a good compromise.The
weekly-releaseworkflow is updated to use this new preset and pick the resulting binaries from the correct locations.