forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 117
fix(debug): Implement reference counter and thread safety in DbgHelpLoader to allow for independent users #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve independent users
slurmlord
reviewed
Nov 5, 2025
slurmlord
approved these changes
Nov 5, 2025
slurmlord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Mauller
reviewed
Nov 7, 2025
Mauller
approved these changes
Nov 7, 2025
Mauller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Critical Section will protect us!
Author
|
Replicated in Generals without conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Pull Request was approved
Debug
Is mostly debug functionality
Fix
Is fixing something, but is not user facing
Minor
Severity: Minor < Major < Critical < Blocker
ThisProject
The issue was introduced by this project, or this task is specific to this project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a reference counter in DbgHelpLoader to allow for independent users.
TODO