Skip to content

fix(parabolicease): Fix asserting on float imprecision in ParabolicEase::setEaseTimes() #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2025
Merged

fix(parabolicease): Fix asserting on float imprecision in ParabolicEase::setEaseTimes() #1854

merged 2 commits into from
Nov 14, 2025

Conversation

@Stubbjax
Copy link

@Stubbjax Stubbjax commented Nov 14, 2025

This change enables the ParabolicEase::setEaseTimes method to better handle floating point imprecision, such as cases where m_in = 0.200000003 and m_out = 0.199999988, without calling a DEBUG_CRASH.

@Stubbjax Stubbjax self-assigned this Nov 14, 2025
@Stubbjax Stubbjax added Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour Fix Is fixing something, but is not user facing labels Nov 14, 2025
@Stubbjax Stubbjax mentioned this pull request Nov 14, 2025
Merged
@xezon xezon added the Debug Is mostly debug functionality label Nov 14, 2025
@xezon xezon changed the title fix: Parabolic ease floating point intolerance fix(parabolicease): Fix floating point intolerant assert in ParabolicEase::setEaseTimes() Nov 14, 2025
@xezon xezon changed the title fix(parabolicease): Fix floating point intolerant assert in ParabolicEase::setEaseTimes() fix(parabolicease): Fix asserting on float inprecision in ParabolicEase::setEaseTimes() Nov 14, 2025
@xezon xezon merged commit b3d7bcb into TheSuperHackers:main Nov 14, 2025
14 checks passed
@Stubbjax Stubbjax deleted the fix-parabolic-ease-floating-point-intolerance branch November 14, 2025 18:07
@Stubbjax Stubbjax changed the title fix(parabolicease): Fix asserting on float inprecision in ParabolicEase::setEaseTimes() fix(parabolicease): Fix asserting on float imprecision in ParabolicEase::setEaseTimes() Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

Assignees

@Stubbjax Stubbjax

Labels

Debug Is mostly debug functionality Fix Is fixing something, but is not user facing Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stubbjax @xezon