Skip to content

Conversation

@Stubbjax
Copy link

This change allows various EVA events (those following the same isLocallyViewed pattern) to be played for the currently observed player, along with a few messages and upgrade completion sound effects.

This includes the following events:

  • EVA_BuildingBeingStolen
  • EVA_BuildingSabotaged
  • EVA_BuildingStolen
  • EVA_BuldingLost [sic]
  • EVA_CashStolen
  • EVA_UnitLost
  • EVA_UpgradeComplete
  • EVA_VehicleStolen

And the following messages:

  • DOZER:ConstructionComplete
  • UPGRADE:UpgradeComplete

@Stubbjax Stubbjax self-assigned this Nov 16, 2025
@Stubbjax Stubbjax added Audio Is audio related Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Nov 16, 2025
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice

Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one more audio event at GeneralsMD\Code\GameEngine\Source\GameLogic\Object\Update\StealthUpdate.cpp(801)

@Stubbjax
Copy link
Author

I think there is one more audio event at GeneralsMD\Code\GameEngine\Source\GameLogic\Object\Update\StealthUpdate.cpp(801)

I avoided that one for this change because it is unrelated to the EVA events. I also need to investigate why just that particular stealth sound (for clearing detected state) is conditional on the local player while none of the others are.

@xezon xezon changed the title feat: Enable more EVA events for observed players tweak(eva): Enable more EVA events for observed players Nov 18, 2025
@xezon xezon merged commit 5de3d63 into TheSuperHackers:main Nov 18, 2025
24 checks passed
@Stubbjax Stubbjax deleted the add-more-observer-events branch November 19, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Audio Is audio related Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants