Skip to content

Conversation

rvolosatovs
Copy link
Contributor

Summary

Fixes nonce type comments

@rvolosatovs rvolosatovs added the c/shared This is shared between components label May 7, 2019
@rvolosatovs rvolosatovs added this to the May 2019 milestone May 7, 2019
@rvolosatovs rvolosatovs requested a review from htdvisser May 7, 2019 09:08
@rvolosatovs rvolosatovs requested a review from johanstokking as a code owner May 7, 2019 09:08
@rvolosatovs rvolosatovs self-assigned this May 7, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.579% when pulling 8814c47 on fix/types into e09ed57 on master.

// DevNonce is randomly generated in the join procedure.
// DevNonce is device nonce used in the join procedure.
// - If LoRaWAN version <1.1 - it is randomly generated.
// - If LoRaWAN version >=1.1 - it is a scrictly increasing counter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be backported to 1.0.4

@rvolosatovs rvolosatovs merged commit 04d01fd into master May 7, 2019
@rvolosatovs rvolosatovs deleted the fix/types branch May 7, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/shared This is shared between components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants