Skip to content

Initial Network Server flow test #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2019
Merged

Initial Network Server flow test #658

merged 4 commits into from
May 14, 2019

Conversation

rvolosatovs
Copy link
Contributor

Summary

Refs #176

Changes

  • Added a simplistic Class A OTAA flow test for EU868 device

@rvolosatovs rvolosatovs added c/network server This is related to the Network Server blocked This can't continue until another issue or pull request is done labels May 7, 2019
@rvolosatovs rvolosatovs added this to the May 2019 milestone May 7, 2019
@rvolosatovs rvolosatovs requested a review from johanstokking as a code owner May 7, 2019 13:11
@rvolosatovs rvolosatovs self-assigned this May 7, 2019
@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented May 7, 2019 •
edited
Loading

Blocked by #652 #655

@coveralls
Copy link

coveralls commented May 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 73.474% when pulling 1536bfb on feature/176-ns-flow-tests into e8fae1d on master.

@johanstokking
Copy link
Member

@rvolosatovs please rebase for review

@rvolosatovs rvolosatovs force-pushed the feature/176-ns-flow-tests branch from 694249f to ccd4622 Compare May 7, 2019 14:32
@rvolosatovs
Copy link
Contributor Author

@johanstokking done

@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label May 7, 2019
johanstokking
johanstokking reviewed May 9, 2019
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is what we need!

Can we generalize that bootstrapping a bit, so that it's easier to add tests without copy pasting whole sections?

@rvolosatovs rvolosatovs force-pushed the feature/176-ns-flow-tests branch 2 times, most recently from 42940ad to 0eb0cb4 Compare May 10, 2019 16:21
@rvolosatovs rvolosatovs requested a review from johanstokking May 10, 2019 16:24
@rvolosatovs rvolosatovs changed the title NS flow test Initial network server flow test May 10, 2019
@rvolosatovs rvolosatovs changed the title Initial network server flow test Initial Network Server flow test May 10, 2019
@rvolosatovs
Copy link
Contributor Author

I improved it a bit. Further generalizations should be done in when we actually work on #176

@rvolosatovs rvolosatovs mentioned this pull request May 13, 2019
Merged
johanstokking
johanstokking approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea to use mock services in pkg/util/test generally in the code base?

@rvolosatovs
Copy link
Contributor Author

Yes!

@rvolosatovs rvolosatovs force-pushed the feature/176-ns-flow-tests branch from 57dcaad to 1536bfb Compare May 14, 2019 15:37
@rvolosatovs rvolosatovs merged commit 3bac859 into master May 14, 2019
@rvolosatovs rvolosatovs deleted the feature/176-ns-flow-tests branch May 14, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels

c/network server This is related to the Network Server

Projects

None yet

Milestone

May 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@rvolosatovs @coveralls @johanstokking