Update query fails when one of the values is empty

[rajbdilip]

Everything was going fine until an update query failed. I then var_dumped the object and found out the class actually doesn't quote the values. The _lastQuery looked something like this.

UPDATE users_temp SET field1= value1,field2= ,field3 = value3 WHERE id = someinteger

Having empty value for field2 caues the query to look like above and failed. I expected the class to quote the values but apparently it doesn't. Checking every value for its emptiness seems a little extra work for me. So, is there any other arrangement in the class for this issue?

[avbdr]

class never quotes values as its using prepared statements.
See documentation about getLastQuery().

update wont fail on empty variable except the case where your field2 is marked as 'not null'.

[rajbdilip]

Is there any documentation beside readme.md?

[avbdr]

nop. I believe readme covers pretty much everything.

[rajbdilip]

Yeah. It does.

I see the class returns false when the update operation doesn't affect any rows. Shouldn't it be returning true when the operation succeeds?

[avbdr]

in reality update() returns an amount of rows updated instead of success/failure.
I agree with your statement and I would rather make it return success/failure and count variable to contain amount of rows affected.

Maybe we can add '-1' as a return value for failed update.

[avbdr]

thanks. After looking at the code its clearly visible that this is a bug.
Please try my repo for a bugfix https://github.com/avbdr/PHP-MySQLi-Database-Class

[rajbdilip]

That worked! Thanks! 👍 :)