Changed inc() and dec() methods to support float #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's valid to increment a field by a float, this allows both ints and floats to be used in increments and decrements.
Collaborator
|
patch looks valid except that I would like to add is_numeric() validation as we are removing int cast.Can you fix and send? |
Contributor
Author
|
Sure thing! Changed to an error when an invalid argument is supplied, checked with is_number(). |
avbdr
added a commit
that referenced
this pull request
Aug 5, 2015
Changed inc() and dec() methods to support float
Collaborator
|
thanks. commited. |
Contributor
Author
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's valid to increment a field by a float, this allows both ints and floats to be used in increments and decrements, while still keeping the default (int)1.