PSR 1&2 code refactoring and exceptions instead of die() #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tommyknocker
commented
Nov 11, 2015
tommyknocker
commented
- Some small refactoring to comply PSR 1 & 2 standard
- Exceptions instead of dying
- new self() in subQuery method
- Exceptions instead of dying - new self() in subQuery method
avbdr
added a commit
that referenced
this pull request
Nov 11, 2015
PSR 1&2 code refactoring and exceptions instead of die()
Collaborator
|
thank you, merged. I were not thinking to change couple dies to exceptions as they will occur mostly during development process, but anyway, let it be like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.