insertMulti implementation by using transactions

[ricwein]

this is a first implementation for MysqliDB:: insertMulti() method to insert multiple datasets at once by utilizing mysql-transactions.

Please excuse the additional changed lines in the commits, where only spaces where deleted. My Editor does this by default.

This is only a proposal and therefor may be not the best or fastest solution.

The changes include:

• added MysqliDB::insertMulti() method into MysqliDb.php
• added tests for insertMulti implementation in tests/mysqliDbTests.php
• added small documentation to readme.md

Please tell, if something should be changed or does not adapt the classes coding style.

[avbdr]

Looks good, but can you please remove all spacing related changes please?

[avbdr]

as well, please make function smaller by remove double \n

[avbdr]

one more observation. insertMulti() will never return false. Seems after rollback you would need to return false. As well, Please check if getLastError and getLastErrId() are returning errors from an actual failed insert() and not from rollback()

[ricwein]

Reverting the spacing changes might by a problem I look into tomorrow.

I just removed some empty lines and unnecessary comments to make the actual method smaller.

I'm not sure what you mean by "insertMulti() will never return false. Seems after rollback you would need to return false". The current behavior is to return an array in success, and false in error case, also after rollback.

Actual getLastError() isn't affected by a rollback(), so this should be no problem.

[avbdr]

you are correct, sorry

[ricwein]

I've reverted all whitespace related changes with the last commit. Anything else to do?

wasn't that simple to remove that damned whitespace-changes without messing up the repo, I hope the master-branch is alright now

[avbdr]

awesome. As for whitespaces, you could just do git checkout and paste back needed code :)

[ricwein]

Well, that would be to simple!

• I soft-reseted to the last commit before my changes
• created a diff with --ignore-all-space --ignore-blank-lines --ignore-space-change as a patch
• actual checked out the old commit and applied the patch
• reset the master HEAD to my new commit

Have a nice weekend, and thanks for merging