Skip to content

Conversation

@liebman
Copy link

@liebman liebman commented Nov 20, 2017

cleaned up the compiler warnings.

TD-er added a commit to TD-er/ESPEasy that referenced this pull request Feb 3, 2018
TD-er added a commit to TD-er/esp8266-oled-ssd1306 that referenced this pull request Feb 3, 2018
Library did some allocs without free and lots of un-initialized variables.

Applied pull requests from esp8266-oled-ssd1306:

ThingPulse#169
ThingPulse#157
ThingPulse#144

And applied the suggestions from issues:
ThingPulse#170
ThingPulse#161

Support multiple display resolutions

Applied PR from esp8266-oled-ssd1306:
ThingPulse#133

Better Brightness / Contrast control

Suggestions taken from this issue:
ThingPulse#134

It is now the same version as being used in ESPeasy.
TD-er added a commit to TD-er/esp8266-oled-ssd1306 that referenced this pull request Feb 3, 2018
Library did some allocs without free and lots of un-initialized variables.

Applied pull requests from esp8266-oled-ssd1306:

ThingPulse#169
ThingPulse#157
ThingPulse#144

And applied the suggestions from issues:
ThingPulse#170
ThingPulse#161

Support multiple display resolutions

Applied PR from esp8266-oled-ssd1306:
ThingPulse#133

Better Brightness / Contrast control

Suggestions taken from this issue:
ThingPulse#134

It is now the same version as being used in ESPeasy.
psy0rz pushed a commit to letscontrolit/ESPEasy that referenced this pull request Feb 5, 2018
* [OLED framed] Backport of OLED lib upgrade from Mega to v2.0

Lots of issues with older lib and the newer version in the Mega branch appeared to be very stable.

* [OLED framed] Use less string allocations

And a first attempt to display the Euro sign. (does not yet work)

* [Special Char] Allow to use special characters

For some special characters, it is often hard to find them and/or use them in URL or JSON streams.
For a subset of supported special characters, a short notation and HTML equivalent is added.
These can be used anywhere.

* [OLED lib] Fixed memory leak

Man library did some allocs without free.
Also unneeded allocs.

* Applied pull requests from esp8266-oled-ssd1306:
ThingPulse/esp8266-oled-ssd1306#169
ThingPulse/esp8266-oled-ssd1306#157
ThingPulse/esp8266-oled-ssd1306#144

And applied the suggestions from issues:
ThingPulse/esp8266-oled-ssd1306#170
ThingPulse/esp8266-oled-ssd1306#161

* [OLED] Support multiple display resolutions

Applied PR from esp8266-oled-ssd1306:
ThingPulse/esp8266-oled-ssd1306#133

* [OLED] Better Brightness / Contrast control

Suggestions taken from this issue:
ThingPulse/esp8266-oled-ssd1306#134

* [OLED] Set contrast to High by default, when no choice was made

Sounds like a valid choice, based on the findings in issue #821

* Compiler error on comments

As suggested here: https://github.com/TD-er/ESPEasy/pull/3/files
@per1234
Copy link
Contributor

per1234 commented Feb 11, 2018

The ESP32 core sets -Werror=all for File > Preferences > Compiler warnings: More or All. Thus, depending on the preference settings, these warnings can actually cause compilation to fail.

Closes #137
Closes #140
Closes #162

@squix78 squix78 merged commit 23ba821 into ThingPulse:master Mar 14, 2018
@liebman liebman deleted the cleanup-warnings branch March 14, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants