Circles improved rings #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circles created with fillCircle() were one pixel taller than wide.
I'm new. Sorry.
Improved existing Circle() functions, added fillRing().
Improved Circle() functions, added fillRing()
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
fillRing(int16_t x, int16_t y, uint16_t radius1, uint16_t radius2, uint8_t quads = B1111, bool improve = false). This function draws a ring. I've also improved the Circle() functions by adding theimproveattribute that checks how much of the circle is shown on the screen. This version has the fixed fillCircle().