Fixed and improved circles + keywords #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old example was another version that I still had for whatever reason and confused with the latest version.
Author
|
Is there anything wrong with this version? |
Member
|
The same issue(s) as with your previous PRs: https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/284/files. As far as Git is concerned you replaced the entire |
Author
|
Yes, but it will be very difficult to find the lines affected and then replace them. I could try, but reluctant. |
Author
|
Can you reject this pull request so that I can create a new version? I don't know how to delete your own forked version ... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains all the improvements of the other three versions: Improved circles, even more improved circles and rings and keywords.