Adds support for also running on NRF52 targets #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my app I noticed that each time I called setTargetFPS the transitions
would become faster and faster, until finally they don't even take one
frame. The problem was that the FP math for calculating changeRatio
would (because of rounding err) keep shrinking the number of ticksPerFrame.
This change instead computs ticksPerFrame/perTransition based on the
requested display time, so error can't accumulate from a series of calls.
(In my app I only bump up target FPS before each transition but then
I lower it down again afterwards to save CPU)
(Also makes it easier to share code when users of library are targeting multiple platforms)
Contributor
Author
|
easier to view here: https://github.com/ThingPulse/esp8266-oled-ssd1306/pull/291/files. If you would prefer me to squash into one commit I can do that. |
Member
No need to, thanks. We usually do a "Squash and merge" when we merge PRs. Your video and my own very brief visual inspection is all I have to assess this. I don't have the hardware to test, but hey, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I just updated this old change based on current master and put it in a separate feature branch)
ESP32 targets are still supported (my project targets both)
Backstory here:
#277