Skip to content

Hm/impl #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haydenmcp merged 2 commits into from
Feb 19, 2018
Merged

Hm/impl #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a6147
added detachment of observer
haydenmcp Feb 18, 2018
3db2800
changed name from isVisible to isVisibleToUser
haydenmcp Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions deep-element-behavior.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
<script>
window.deep = window.deep || {};

// TODO: JSDoc
ElementBehaviorImpl = {
properties: {
/* True if the element is visible to the user. False otherwise. */
isVisible: {
isVisibleToUser: {
type: Boolean,
value: false
},
/* Observer monitoring resize events */
__resizeObserver: Object
},
attached() {
this.__resizeObserver = new ResizeObserver(this.__updateVisibility);
this.__resizeObserver = new ResizeObserver(this.__updateVisibility.bind(this));
this.__resizeObserver.observe(this);
},
detached() {

this.__resizeObserver.disconnect();
},
__updateVisibility(resizeEntries) {
if(!Array.isArray(resizeEntries) || !resizeEntries.length) return;
const boundingRectangle = resizeEntries[0].contentRect;
const {height, width} = boundingRectangle;
this.set('isVisible', Boolean(height) || Boolean(width));
this.set('isVisibleToUser', Boolean(height) || Boolean(width));
}
};
deep.ElementBehavior = [ElementBehaviorImpl];
Expand Down