Fixed Drag and Drop behaviour #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thundernerd
approved these changes
Jul 22, 2022
Owner
Thundernerd
left a comment
Thundernerd
left a comment
There was a problem hiding this comment.
Looks good but it seems there is a merge conflict. Once this has been resolved I'll merge the PR
…DragAndDrop-ReferenceDrawer
Thundernerd
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rawReferencewas null.ReferenceDrawer.HandleDragAndDrop(), it would process drag and drop even if the mouse was outside the propertyHandleDragUpdated()must be done beforeHandleDragPerform(), otherwise, the mode will always be None.This fixes #22
Note
A thing we noted is that, in lists and arrays, SerializableInterfaces are always defaulted at ReferenceMode.Raw, while fields are defaulted at ReferenceMode.Unity. But then, switching the enum's value ( { Unity, Raw } instead of { Raw, Unity } ), defaults them at ReferenceMode.Unity.
Oh well.