Take into account var-sized fields in SparseTensorSchema.max_partition_weight #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsakkis
changed the title
…ke into account var-sized fields
gsakkis
force-pushed
the
gsa/fix-SparseTensorSchema.max_partition_weight
branch
from
176ced0 to
a6aabb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparseTensorSchema.max_partition_weightdetermines the number of (non-empty) sparse array cells that can fit in a given memory budget. After #153 and #157, these cells may be var-sized in case the key dimension is string.This PR updates
SparseTensorSchema.max_partition_weightto compute the average number of bytes needed for var-sized cells.