Refactor parametric test utils #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsakkis
force-pushed
the
gsa/refactor-parametric-tests
branch
4 times, most recently
from
8b9008b to
c22312f
Compare
gsakkis
force-pushed
the
gsa/refactor-parametric-tests
branch
3 times, most recently
from
3f57546 to
0c36151
Compare
gsakkis
force-pushed
the
gsa/refactor-parametric-tests
branch
from
0c36151 to
05906db
Compare
ktsitsi
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parametric tests for loaders have grown quite a few parameters, some of them duplicated for the
xandyarray.Similarly to #158, this PR simplifies
parametrize_for_datasetby bundling the test parameters for each array into anArraySpecdataclass.Also update
PyTorchTileDBDataLoaderto fail early ifnum_workers>0and any tensor schema is not dense due to pytorch/pytorch#20248.