Skip to content

Conversation

@gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Sep 6, 2022

The unit test suite has grown too large, mainly due to many parameter combinations generated by parametrize_for_dataset. This PR reduces the number of generated parametrizations by:

  • merging some parameters (x_sparse/y_sparse -> sparse and similarly for all x_*/y_* parameters)
  • removing parameters that don't offer much/any value from some tests (e.g. batch_size, shuffle_buffer_size, num_workers from test_unequal_num_keys).

While at it, some new tests were added:

  • shuffle_buffer_size was tested by default only for a single value (16), now it is tested for both 0 and 16.
  • test_csr was added in test_tensorflow (currently asserts that NotImplementedError is raised).

Number of tests:

  • at the base of this branch (defb304):
$ pytest tests/ --collect-only | tail -1
======================== 10572 tests collected in 4.09s ========================
$ pytest tests/ --collect-only | tail -1
======================== 3336 tests collected in 3.25s =========================

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #20800: Simplify parametric tests.

Copy link
Collaborator

@ktsitsi ktsitsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsakkis gsakkis force-pushed the gsa/sc-20800/simplify-parametric-tests branch from ca7f390 to b305c37 Compare September 7, 2022 07:53
@gsakkis gsakkis force-pushed the gsa/sc-20195/fix-pytorch-batch-size-none branch from ad49d73 to defb304 Compare September 7, 2022 08:17
@gsakkis gsakkis force-pushed the gsa/sc-20800/simplify-parametric-tests branch from 976fdd8 to 582acb0 Compare September 7, 2022 13:15
Copy link
Contributor

@georgeSkoumas georgeSkoumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsakkis gsakkis changed the base branch from gsa/sc-20195/fix-pytorch-batch-size-none to master September 9, 2022 14:41
@gsakkis gsakkis force-pushed the gsa/sc-20800/simplify-parametric-tests branch from 582acb0 to 7e99faa Compare September 9, 2022 14:42
@gsakkis gsakkis merged commit 0a41d22 into master Sep 9, 2022
@gsakkis gsakkis deleted the gsa/sc-20800/simplify-parametric-tests branch September 9, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants