Package _tensor_schema #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsakkis
force-pushed
the
gsa/package_tensor_schema
branch
from
9130367 to
ce500aa
Compare
gsakkis
force-pushed
the
gsa/support-pytorch-1.11
branch
from
0ac4f8b to
49fdbe2
Compare
gsakkis
force-pushed
the
gsa/package_tensor_schema
branch
from
ce500aa to
ae5283a
Compare
gsakkis
changed the base branch from
master
to
gsa/sc-21303/support-reading-dense-tensors-from-sparse-arrays
georgeSkoumas
approved these changes
Sep 15, 2022
Base automatically changed from
gsa/sc-21303/support-reading-dense-tensors-from-sparse-arrays
to
master
September 15, 2022 20:35
gsakkis
force-pushed
the
gsa/package_tensor_schema
branch
from
ae5283a to
32b33fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_tensor_schemamodule has grown quite a bit since it was introduced. This PR refactors it to a package and moves eachTensorSchemasubclass/factory to a separate module. Additionally, theTensorKindenum and theSelectortype alias that are part of the public API (since they are used byArrayParams) are moved from_tensor_schematotypes.