Visual-dialog 0.7 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creation of the TextBox class which allows to encapsulate all attributes and generalist methods. DialogBox now inherits this class. utils.py contains the non-library related functions used by the main files. Addition two new propertys to TextBox class : TextBox.position and TextBox.dimensions. Parameters title and title_colors_pair_nb are now no longer required to instanciation of TextBox and DialogBox. color_pair_nb parameter is now optionnal in DialogBox.char_by_char and DialogBox.word_by_word methods (set by default to 1). The default delay between each character is now 0.04s instead of 0.05s in DialogBox.char_by_char method. Change in the way the title of the TextBox works : the default title is an empty string and is only displayed in if it is non-empty. Added more accurate hinting typing in the signatures of the function. Addition of instructions to built documentation in README. Typo minors change in documentation. Start writing a tutorial. Moving the tests contained in core.py to /tests/test.py Start implementing the ChoiceBox class to provide selectable choices in dialog.py Start implementing panic feature in box.py
…ess shebangs at top of file. Make cargs as default argument.
…instruction to build doc in README. Change in README. Remove condition to call callback in DialogBox.word_by_word and char_by_char. Change parameter name of TextBox.box_width and TextBox.box_length to width and length.
…xt attributes instead of a tuple contains once in some methods, correction of typing hinting.
…instructions, remove Makefile and make.bat.
…isplayed the textbox two characters below when the title was empty.
… method and not the behavior of the parent TextBox class, improve examples.
…n in rst in utils.py.
…orts, fix import in choices.py, pep8 fixes.
|
Beep Beep! I found some formatting errors in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.