fix: process deep-cloned entities in a queue for GizmoSolutionCloner #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Oct 1, 2025
.../java/ai/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerTest.java
Outdated
Show resolved
Hide resolved
.../java/ai/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerTest.java
Outdated
Show resolved
Hide resolved
...est/java/ai/timefold/solver/core/impl/domain/solution/cloner/AbstractSolutionClonerTest.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Outdated
Show resolved
Hide resolved
...i/timefold/solver/core/impl/domain/solution/cloner/gizmo/GizmoSolutionClonerImplementor.java
Show resolved
Hide resolved
Christopher-Chianelli
force-pushed
the
fix/deeply-nested-gizmo-cloning
branch
from
8243a82 to
3367128
Compare
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Oct 3, 2025
- Previously, when a class is deep-cloned, a method that constructs and fully initializes a clone of that class is called. This has the potential to cause a StackOverflowException when a deep-cloned class refers to many other deep-cloned classes, such as in chained models. - Now, when a field is deeped cloned, it adds the field initializer to a cloneQueue, and that cloneQueue can only be processed for the first entity being cloned. As such, stack-height does not grow indefinitely. - Perform various cleanups in the GizmoSolutionCloner - Change method `isInvalid` to `getIsInvalid` so the GizmoSolutionCloner recongize it as the getter of the corresponding field.
Christopher-Chianelli
force-pushed
the
fix/deeply-nested-gizmo-cloning
branch
from
3367128 to
93410ca
Compare
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a class is deep-cloned, a method that constructs and fully initializes a clone of that class is called. This has the potential to cause a StackOverflowException when a deep-cloned class refers to many other deep-cloned classes, such as in chained models.
Now, when a field is deeped cloned, it adds the field initializer to a cloneQueue, and that cloneQueue can only be processed for the first entity being cloned. As such, stack-height does not grow indefinitely.
Perform various cleanups in the GizmoSolutionCloner
Change method
isInvalidtogetIsInvalidso the GizmoSolutionCloner recongize it as the getter of the corresponding field.