--no-keep_going does not work

[vlkv]

Hello,
Flag --no-keep_going seems to be ignored. How I reproduce this:

v.volkov@developers ~/monorepo
 % ./bazelisk run @bazel-diff//cli:bazel-diff -- generate-hashes \
    --excludeExternalTargets \
    -b "./bazelisk" \
    -w "$(pwd)" \
    --includeTargetType --no-keep_going \
    "/tmp/starting_hashes.json"
DEBUG: /home/v.volkov/.cache/bazel/_bazel_v.volkov/4cab2e50b12d32f1398e821ec5166cdb/external/rules_jvm_external+/private/lib/coordinates.bzl:76:18: Assuming com.google.code.gson:gson:jar:2.9.0 should be interpreted as com.google.code.gson:gson:2.9.0@jar
DEBUG: /home/v.volkov/.cache/bazel/_bazel_v.volkov/4cab2e50b12d32f1398e821ec5166cdb/external/rules_jvm_external+/private/lib/coordinates.bzl:76:18: Assuming info.picocli:picocli:jar:4.6.3 should be interpreted as info.picocli:picocli:4.6.3@jar
INFO: Analyzed target @@bazel-diff+//cli:bazel-diff (219 packages loaded, 13013 targets configured).
INFO: Found 1 target...
Target @@bazel-diff+//cli:bazel-diff up-to-date:
  bazel-bin/external/bazel-diff+/cli/bazel-diff
  bazel-bin/external/bazel-diff+/cli/bazel-diff.jar
INFO: Elapsed time: 0.773s, Critical Path: 0.01s
INFO: 1 process: 792 action cache hit, 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/external/bazel-diff+/cli/bazel-diff <args omitted>
 no actions running
Loading: 0 packages loaded
ERROR: Failed to get information about path, for bazel-wd, skipping: /root/.cache (Permission denied)
ERROR: /home/v.volkov/monorepo/backend/trading/trd_adaptor/internal/redis/BUILD.bazel:19:1: name 'go_test' is not defined (did you mean 'sh_test'?)
ERROR: package contains errors: backend/trading/trd_adaptor/internal/redis
DEBUG: /home/v.volkov/.cache/bazel/_bazel_v.volkov/4cab2e50b12d32f1398e821ec5166cdb/external/gazelle+/internal/bzlmod/go_deps.bzl:631:36: The following Go modules were required by the root module at the given versions, but were implicitly updated to higher versions due to transitive dependencies:
 
  github.com/golang/mock: v1.6.0 -> v1.7.0-rc.1 

Update the root module's dependencies to match the resolved versions via:

  bazel run @rules_go//go -- get github.com/golang/mock@v1.7.0-rc.1 

DEBUG: /home/v.volkov/.cache/bazel/_bazel_v.volkov/4cab2e50b12d32f1398e821ec5166cdb/external/aspect_rules_js+/npm/private/npm_translate_lock_state.bzl:316:18: 
WARNING: Implicitly using package.json file `@@//:backend/marketdata/md-source-coinapi-trade/package.json` since the `@@//:pnpm-lock.yaml` file contains this workspace package.
    Add '@@//:backend/marketdata/md-source-coinapi-trade/package.json' to the 'data' attribute of `npm_translate_lock(name = "npm")` to suppress this warning.
DEBUG: /home/v.volkov/.cache/bazel/_bazel_v.volkov/4cab2e50b12d32f1398e821ec5166cdb/external/aspect_rules_js+/npm/private/npm_translate_lock_state.bzl:316:18: 
WARNING: Implicitly using package.json file `@@//:backend/proto/package.json` since the `@@//:pnpm-lock.yaml` file contains this workspace package.
    Add '@@//:backend/proto/package.json' to the 'data' attribute of `npm_translate_lock(name = "npm")` to suppress this warning.
ERROR: package contains errors: backend/trading/trd_adaptor/internal/redis: name 'go_test' is not defined (did you mean 'sh_test'?)
WARNING: --keep_going specified, ignoring errors. Results may be inaccurate

As you can see

• I have a problem in one of my BUILD files to simulate broken build
• I pass --no-keep_going flag to the bazel-diff generate-hashes
• I get the output that "--keep_going specified" which is not what I expect.

I am using this version of bazel-diff:

bazel_dep(name = "bazel-diff", version = "10.1.0")

Please fix this, it is really needed in my monorepo build.

Kind regards.

[tinder-maxwellelliott]

Can you try out #283 ?