fix: stack overflow error when generating hashes #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if a rule ends up depending on itself. To check for this we simply avoid trying to create a digest for a rule of the same name as the current one we're working on. Fixes: Tinder#71
|
|
tinder-maxwellelliott
approved these changes
Jul 6, 2021
tinder-maxwellelliott
added a commit
that referenced
this pull request
Jul 6, 2021
Adds a test for a recent fix added in #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if a rule ends up depending on itself.
To check for this we simply avoid trying to create a digest for a rule
of the same name as the current one we're working on.
Fixes: #71