Fix bug during registration of generating targets #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
@KevinJiao this looks good to me, you just need to sign the CLA |
Fixes a bug where if the generating rule name is lexicographically after the generated rule, changes in the generating rule are not picked up by targets that depend on the generated rule. Test plan: Added unit test demonstrating buggy behavior.
Contributor
Author
|
CLA is signed. (I think you need to approve the CI build as this is my first contribution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the generating rule name is lexicographically after
the generated rule, changes in the generating rule are not picked up by
targets that depend on the generated rule.
When this happens between a generating rule and generated rule,
the generated rule's entry in
allRulesMapis null, as the generatingrule hasn't been processed yet. If a rule has no entry in
allRulesMap,it's hash is unable to be used as a dependency in
createDigestForRule,resulting in missing impacted targets.
Test plan:
Added unit test demonstrating buggy behavior.