Skip to content

🚨 Use logger Instead Of warnings for wsireader.py #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2023
Merged

🚨 Use logger Instead Of warnings for wsireader.py #584

merged 4 commits into from
Apr 21, 2023

Conversation

@shaneahmed
Copy link
Member

  • Use logger Instead Of warnings for wsireader.py

@shaneahmed
🚨 DEV: Use logger Instead Of warnings for wsireader.py
5bf1eaf 
- Use `logger` Instead Of `warnings` for `wsireader.py`
@shaneahmed shaneahmed self-assigned this Apr 5, 2023
@shaneahmed shaneahmed requested a review from measty April 5, 2023 15:08
@shaneahmed shaneahmed changed the title 🚨 DEV: Use logger Instead Of warnings for wsireader.py 🚨 Use logger Instead Of warnings for wsireader.py Apr 5, 2023
@shaneahmed
🧪 Fix failing test
acace81 
- Fix failing test
@shaneahmed shaneahmed added the enhancement New feature or request label Apr 5, 2023
@shaneahmed
✅ Add tests for wsimeta
40a8183 
- Add tests for `wsimeta`
@codecov
Copy link

codecov bot commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #584 (e9507b7) into develop (e9b7768) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
- Coverage    99.63%   99.63%   -0.01%     
===========================================
  Files           62       62              
  Lines         6626     6608      -18     
  Branches      1081     1073       -8     
===========================================
- Hits          6602     6584      -18     
  Misses          15       15              
  Partials         9        9
Impacted Files Coverage Δ
tiatoolbox/models/dataset/classification.py 100.00% <100.00%> (ø)
tiatoolbox/tools/patchextraction.py 100.00% <100.00%> (ø)
tiatoolbox/tools/registration/wsi_registration.py 99.50% <100.00%> (ø)
tiatoolbox/wsicore/wsimeta.py 100.00% <100.00%> (ø)
tiatoolbox/wsicore/wsireader.py 99.42% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed shaneahmed added this to the Release v1.4.0 milestone Apr 10, 2023
measty
measty approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@measty measty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@shaneahmed shaneahmed merged commit 7541f57 into develop Apr 21, 2023
@shaneahmed shaneahmed deleted the dev-use-logger-for-wsireader branch April 21, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@measty measty measty approved these changes

Assignees

@shaneahmed shaneahmed

Labels

enhancement New feature or request

Projects

None yet

Milestone

Release v1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shaneahmed @measty