Skip to content

🚨 Use logger Instead Of warnings for utils Package #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2023
Merged

🚨 Use logger Instead Of warnings for utils Package #586

merged 4 commits into from
Apr 14, 2023

Conversation

@shaneahmed
Copy link
Member

  • Use logger Instead Of warnings for utils Package

@shaneahmed
🚨 Use logger Instead Of warnings for utils Package
00acc72 
- Use `logger` Instead Of `warnings` for `utils` Package

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@shaneahmed shaneahmed requested a review from adamshephard April 10, 2023 09:59
@shaneahmed shaneahmed added this to the Release v1.4.0 milestone Apr 10, 2023
@shaneahmed shaneahmed self-assigned this Apr 10, 2023
@shaneahmed shaneahmed added the enhancement New feature or request label Apr 10, 2023
@shaneahmed
🧪 Fix failing test
5482c34 
- Fix failing test

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #586 (8f1cb08) into develop (df7655d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #586      +/-   ##
===========================================
+ Coverage    99.63%   99.74%   +0.10%     
===========================================
  Files           62       62              
  Lines         6609     6616       +7     
  Branches      1073     1073              
===========================================
+ Hits          6585     6599      +14     
+ Misses          15        8       -7     
  Partials         9        9
Impacted Files Coverage Δ
tiatoolbox/utils/image.py 100.00% <100.00%> (ø)
tiatoolbox/utils/misc.py 100.00% <100.00%> (ø)
tiatoolbox/utils/visualization.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shaneahmed
shaneahmed commented Apr 14, 2023
View reviewed changes
@shaneahmed shaneahmed merged commit f331aac into develop Apr 14, 2023
@shaneahmed shaneahmed deleted the dev-use-logger-for-utils branch April 14, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamshephard adamshephard Awaiting requested review from adamshephard

Assignees

@shaneahmed shaneahmed

Labels

enhancement New feature or request

Projects

None yet

Milestone

Release v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shaneahmed