Skip to content

Conversation

@tanoabeleyra
Copy link

Hello,

A NoReverseMatch exception is thrown during signup when using django-allauth and ACCOUNT_EMAIL_VERIFICATION is set to 'mandatory'.
This happen because django-allouth tries to reverse a missing route: https://github.com/pennersr/django-allauth/blob/master/allauth/account/adapter.py#L458.

I added an empty view to avoid this.
The view was already there some time ago and removed on this commit: 0fc4d56#diff-c6d8840dbabc2fb43a1d18876004f17a. Please let me know if it was any reason for this, I can't see any.

This can also be avoided by importing django-allauth urls but I would prefer not to. Also, the documentation doesn't say you should.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.365% when pulling c5970df on tanoabeleyra:master into 479a40d on Tivix:master.

@tanoabeleyra
Copy link
Author

Given the lack of response here (and most of the PR/issues) I'll just make a fork, thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants