Add missing django-allauth empty View #458
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A
NoReverseMatchexception is thrown during signup when using django-allauth andACCOUNT_EMAIL_VERIFICATIONis set to'mandatory'.This happen because django-allouth tries to reverse a missing route: https://github.com/pennersr/django-allauth/blob/master/allauth/account/adapter.py#L458.
I added an empty view to avoid this.
The view was already there some time ago and removed on this commit: 0fc4d56#diff-c6d8840dbabc2fb43a1d18876004f17a. Please let me know if it was any reason for this, I can't see any.
This can also be avoided by importing django-allauth urls but I would prefer not to. Also, the documentation doesn't say you should.