Feat!: Require dialect arg in sqlmesh config#1127

Merged

treysp merged 51 commits intomainfrom

trey/dialectconfig

Jul 18, 2023

Contributor

treysp commented Jul 11, 2023

No description provided.

treysp added 4 commits

July 11, 2023 09:23


          Require dialect arg in sqlmesh init

8c62af4


          Require dialect arg in init magic

446ca9c


          Require config to have dialect

9fcb8f5


          Quote dialect in sqlmesh init dbt config

520d95b

tobymao reviewed

View reviewed changes

sqlmesh/cli/main.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/core/context.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/core/context.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/magics.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/magics.py Outdated

treysp added 3 commits

July 11, 2023 15:12


          PR feedback

e38eb2b


          Merge branch 'main' into trey/dialectconfig

bed41e0


          Remove redundant dialect validation

f874ab7

tobymao reviewed

View reviewed changes

sqlmesh/cli/main.py Outdated

treysp added 11 commits

July 12, 2023 12:55


          Make sqlglot_dialects a public util function

adee2da


          Remove dialect default enforcement from context

d9ac85f


          Merge main

3d9581e


          Make project configs and model default dialect mandatory

6b9b6c1


          Add model default dialect to sushi configs

96a722b


          Update tests with model default dialect

4212df0


          Add defaults for input paths

0c59d09


          Fix test_config

2702fe5


          Merge branch 'main' into trey/dialect-no-pydantic

552901b


          Merge branch 'main' into trey/dialectconfig

17cb231


          Merge branch 'trey/dialect-no-pydantic' into trey/dialectconfig

11b8573

eakmanrq reviewed

View reviewed changes

sqlmesh/core/config/loader.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/core/config/model.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/core/config/loader.py Outdated

tobymao reviewed

View reviewed changes

sqlmesh/core/config/loader.py Outdated

treysp added 2 commits

July 14, 2023 12:52


          Fix airflow init template

e13eb42


          Convert cli init dialect from option to arg

3e6a8c9

treysp added 17 commits

July 14, 2023 15:43


          Add model default dialect to test sushi dbt configs

9d0056c


          Add model default dialect to example sushi dbt config

62ff637


          Merge branch 'main' into trey/dialectconfig

96095e3


          Add model default dialect to example multi configs

f768d24


          Fix web tests

74fae8a


          Add init dialect to documentation

b7f3558


          Fix cli click argument


          Update notebook quickstart and magics

873f28a


          Update notebook quickstart text

6ed9e81


          Update sushi dbt example config

931af5d


          Expand error message for no default dialect

8e90358


          Change init dbt template to use dialect string


          Pass SQLMesh default dialect to dbt context

ffdc728


          Update sushi dbt tests yet again

2c5c453


          Merge branch 'main' into trey/dialectconfig

c5516a8


          Docs typos

179716c


          Change example configs to duckdb dialect

3de01ce

treysp marked this pull request as ready for review

July 14, 2023 23:30

treysp added 2 commits

July 14, 2023 18:33


          Change more example configs to duckdb dialect

0065f8d


          Update test_context with new sushi duckdb dialect

64abf71

treysp requested review from crericha and tobymao

July 14, 2023 23:53


          Add test for python config

a3b2431

tobymao reviewed

View reviewed changes

sqlmesh/core/config/loader.py Outdated

treysp added 3 commits

July 17, 2023 08:38


          Merge branch 'main' into trey/dialectconfig

7d7b31b


          Update notebook and cli docs

c22d730


          PR feedback

ce308e0

tobymao approved these changes

View reviewed changes

treysp merged commit f8d5041 into main

treysp deleted the trey/dialectconfig branch

July 18, 2023 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet