Fix: Adjustments to new layout based on feedback#2011
Merged
Conversation
mykalmax
force-pushed
the
fix-remove-tags
branch
2 times, most recently
from
2a3337f to
a6e5d8f
Compare
vchan
approved these changes
Jan 25, 2024
mykalmax
force-pushed
the
fix-remove-tags
branch
2 times, most recently
from
bc12479 to
9fd4bdf
Compare
mykalmax
force-pushed
the
fix-remove-tags
branch
from
9fd4bdf to
c441c57
Compare
vchan
approved these changes
Jan 25, 2024
|
|
||
| void planRun() | ||
| } | ||
| }, [models]) |
Contributor
There was a problem hiding this comment.
Is it better to have the dependency be models.size instead of models? Or it doesn't matter?
Contributor
Author
There was a problem hiding this comment.
having models.size may not catch when some value that models map holds has changed
| } | ||
| }, [models]) | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
This looks very similar to the effect hook above it. Is that intentional?
| if (isNotNil(value)) { | ||
| setPlanAction(new ModelPlanAction({ value })) | ||
| } | ||
| // This inconsistency can happen when we recived flag from the backend |
Contributor
There was a problem hiding this comment.
Suggested change
| // This inconsistency can happen when we recived flag from the backend | |
| // This inconsistency can happen when we receive flag from the backend |
web/server/api/endpoints/meta.py
Outdated
|
|
||
|
|
||
| class Mode(str, enum.Enum): | ||
| DEFAULT = "default" # Allow all modules |
Contributor
There was a problem hiding this comment.
Nit: How about ALL instead of DEFAULT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.