Feat: Create snapshot tables on demand#2028
Merged
izeigerman merged 6 commits intomainfrom Jan 26, 2024
Merged
Conversation
tobymao
reviewed
Jan 26, 2024
tobymao
reviewed
Jan 26, 2024
tobymao
reviewed
Jan 26, 2024
7ee011a to
2c488a0
Compare
eakmanrq
reviewed
Jan 26, 2024
eakmanrq
reviewed
Jan 26, 2024
Collaborator
|
Since you added a public method usually these get a test added in |
28f4e83 to
e68bbcb
Compare
Collaborator
Author
|
@eakmanrq added additional tests |
eakmanrq
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes sure that physical tables for snapshots are created lazily when they are actually needed. This is particularly helpful when using the model selector, in which case we create tables for selected models only.
Additionally, this update has a nice side effect of adding self-healing properties to the plan / apply flow by automatically re-creating snapshot tables if they happen to be missing.