fix: context close on Create/Update/Delete operations#2038
Merged
Conversation
eakmanrq
changed the title
izeigerman
approved these changes
Jan 29, 2024
Collaborator
izeigerman
left a comment
izeigerman
left a comment
There was a problem hiding this comment.
Show we do this in the except block?
Contributor
|
or finally? |
Collaborator
|
yes, thanks, @tobymao , that's what I meant |
eakmanrq
force-pushed
the
eakmanrq/cli_context_close
branch
from
9fa1cf0 to
d5e5d79
Compare
izeigerman
force-pushed
the
eakmanrq/cli_context_close
branch
from
8da453e to
6bfca9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fix for this issue: #2037
It makes sense that we close connections when using CLI prior to exiting. Open question about how we would mimic this in environments with long-running python instances (Notebook/UI) but fixing in CLI for now.