Merged
Conversation
z3z1ma
force-pushed
the
feat/typed-macros
branch
from
f1824ce to
e97a9e2
Compare
Contributor
Author
|
Rebased on main after ryans merges and everythings passing |
z3z1ma
commented
Jan 29, 2024
tobymao
reviewed
Jan 30, 2024
Contributor
|
can you update the documentation to indicate this new behavior of type annotations? |
tobymao
reviewed
Jan 30, 2024
z3z1ma
force-pushed
the
feat/typed-macros
branch
3 times, most recently
from
0bce05e to
6199210
Compare
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
z3z1ma
force-pushed
the
feat/typed-macros
branch
2 times, most recently
from
f1bb463 to
8c21a86
Compare
tobymao
reviewed
Feb 1, 2024
Contributor
|
one last small suggestion. can we get a lot more tests, basically covering the gamut of coercisions and docs? thanks @z3z1ma ! after comprehensive tests and docs this is good to go |
Contributor
Author
|
cool thanks for help @tobymao you rock. i will get to the tests and docs tomorrow |
z3z1ma
force-pushed
the
feat/typed-macros
branch
from
dd682bc to
62f7115
Compare
z3z1ma
force-pushed
the
feat/typed-macros
branch
from
2534cc8 to
30658cb
Compare
Contributor
Author
|
@tobymao I added tests that hit every code path I think, I might add another 1 or 2. But otherwise going to focus on the docs. |
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
tobymao
reviewed
Feb 1, 2024
eakmanrq
added a commit
that referenced
this pull request
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A spike at allowing users to explicitly define types for macro arguments. This makes the interface a little bit nicer since you know exactly what you are gonna get. The implementation is a proof of concept at where we may add this functionality.
Thoughts?