Feat: more configuration for format command#2048
Merged
tobymao merged 2 commits intoSQLMesh:mainfrom Jan 30, 2024
Merged
Conversation
Collaborator
|
@z3z1ma Can you also add these to the magic command? https://github.com/TobikoData/sqlmesh/blob/main/sqlmesh/magics.py#L627 |
Contributor
Author
|
You bet! Done @eakmanrq |
tobymao
reviewed
Jan 30, 2024
| """Format all SQL models.""" | ||
| args = parse_argstring(self.format, line) | ||
| context.format(args.transpile, args.new_line) | ||
| context.format(**vars(args)) |
Contributor
Author
There was a problem hiding this comment.
The arg parser returns a Namespace. vars accesses the __dict__ attribute basically. On namespaces, this is a well defined behavior and way to convert it to a dict.
Contributor
Author
There was a problem hiding this comment.
See stdlib docs mention the same
https://docs.python.org/3/library/argparse.html#the-namespace-object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not enough configurability. Expose very nice implementation in Generator to the benefit of all users while preserving existing behavior by default.