Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/add_dbt_snapshot_feature_flag
branch
from
3a0eb43 to
563ee5d
Compare
crericha
reviewed
Feb 5, 2024
sqlmesh/core/config/feature_flag.py
Outdated
Contributor
There was a problem hiding this comment.
We want the feature flag to be dbt specific?
Contributor
There was a problem hiding this comment.
my guess is that this is a categorization for dbt specific feature flags
Collaborator
Author
There was a problem hiding this comment.
Yeah this feature flag is dbt specific. If native users start using a new SCD Type 2 feature and they hit an error they can just remove it and not affect prod. In dbt, since we used to ignore snapshots and now we process them, their prod becomes affected and therefore this FF is an easy to reach stability again. Therefore it is dbt focused.
eakmanrq
force-pushed
the
eakmanrq/add_dbt_snapshot_feature_flag
branch
from
563ee5d to
0e3333e
Compare
izeigerman
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature flag for disabling SCD Type 2 Support (or called "Snapshots" in dbt) using the dbt adapter. This would disable all Snapshot models. The plan is to remove this in a few weeks if we find it is not needed as we continue to rollout full Snapshot support to dbt models.