Merged
Conversation
|
|
tobymao
reviewed
Feb 7, 2024
| new_kwarg: exp.ColumnDef, | ||
| ) -> t.List[TableAlterOperation]: | ||
| current_type = exp.DataType.build(current_type) | ||
| # We don't copy on purpose here because current_type may need to be mutated inside |
Contributor
There was a problem hiding this comment.
why does data.build mutate?
Collaborator
Author
There was a problem hiding this comment.
It doesn't mutate, it copies current_type which caused an issue in this module because we are mutating the struct expression in several places (search for .pop and .insert calls, as mentioned in the comment)
Collaborator
Author
There was a problem hiding this comment.
so before my sqlglot commit we weren't copying inside DataType.build and this worked because the mutations were being propagated here, now that we copy they don't unless I switch it off here
tobymao
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was super annoying to detect the need for the L458 change in schema_diff.py (triggered by a recent change in sqlglot), may need to refactor this at some point to avoid the mutations if possible.