Merged
Conversation
tobymao
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handlers are shared globally which was causing an issue where Airflow tests would add handlers and those handlers would then affect the results of other tests (like upcoming CLI tests: #2091)
I initially tried fixing Airflow directly by setting
_AIRFLOW__AS_LIBRARYwithin a autouse fixture but that broke some tests and also required that imports for Airflow be within the scope of functions which was annoying. This solution though helps rescope logger to not share state across modules which seems more broadly useful. I decided to scope it to modules instead of functions because I want to make it easy for future tests to configure logging at the module level and not have this override it.