Feat!: Automatically compute previews for changed forward-only models in dev#2108
Merged
izeigerman merged 1 commit intomainfrom Feb 8, 2024
Conversation
izeigerman
force-pushed
the
automatically-set-preview-start-when-forward-only-model-changed
branch
from
7642a3c to
28a2456
Compare
tobymao
reviewed
Feb 8, 2024
tobymao
approved these changes
Feb 8, 2024
izeigerman
changed the title
izeigerman
deleted the
automatically-set-preview-start-when-forward-only-model-changed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the additional
--enable-previewflag (and a corresponding config option) to the plan command, which enables automatic computation of data previews for changes applied to forward-only models in development environments.Previously, to achieve the same outcome (compute previews), users had to run two plan commands: 1) to apply forward-only changes, and 2) to restate affected models in dev so that the portion of data is recomputed to make the preview available.