Conversation
tobymao
approved these changes
Feb 13, 2024
treysp
reviewed
Feb 13, 2024
treysp
reviewed
Feb 13, 2024
treysp
approved these changes
Feb 13, 2024
eakmanrq
force-pushed
the
eakmanrq/add_tstz_support_2
branch
from
cf840ff to
15b7bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change
tscould contain timezone information if that was passed in and would cause issues for some engines. Now we make sure thattsdoes not contain timezone andtstzdoes.Took the opportunity to reduce some extra code in engine adapter and write some tests to ensure we could cast the values correctly across all engines. Also ran the engine adapter integration tests across all engines (including remote) to ensure it works.