Fix: Never ignore forward-only snapshots when building a plan#2227
Merged
izeigerman merged 1 commit intomainfrom Mar 6, 2024
Merged
Fix: Never ignore forward-only snapshots when building a plan#2227izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
izeigerman
force-pushed
the
fix-never-ignore-forward-only-snapshots-in-plan
branch
from
7ea8972 to
0b90125
Compare
tobymao
approved these changes
Mar 6, 2024
izeigerman
force-pushed
the
fix-never-ignore-forward-only-snapshots-in-plan
branch
from
0b90125 to
cf1978f
Compare
eakmanrq
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we might end up ignoring forward-only snapshots / models in dev, even though the resulting data will only be used for preview purposes.
This fix ensures that we never ignore forward-only models / snapshots when constructing a plan.