fix!: recursively check for unknown data types#2235
Merged
Conversation
tobymao
reviewed
Mar 8, 2024
tobymao
reviewed
Mar 8, 2024
eakmanrq
force-pushed
the
eakmanrq/recursively_check_unknown_data_types
branch
from
0d25142 to
b9aa921
Compare
eakmanrq
force-pushed
the
eakmanrq/recursively_check_unknown_data_types
branch
from
b9aa921 to
7972927
Compare
georgesittas
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change you could have a struct with a unknown data type in it and we would consider this as having all the data types defined. This PR makes the data type check recursive so we will find unknown types in nested data types.
SchemaDifferwas changed because I converted a classmethod it had into a utility function. No logic changes to that class or it's tests.