Feat: truncate comments to engine-specific maximum#2238
Merged
Conversation
crericha
reviewed
Mar 8, 2024
crericha
reviewed
Mar 8, 2024
Contributor
eakmanrq
reviewed
Mar 9, 2024
eakmanrq
approved these changes
Mar 9, 2024
Collaborator
eakmanrq
left a comment
eakmanrq
left a comment
There was a problem hiding this comment.
Nice! One small change requested.
treysp
force-pushed
the
trey/comment-truncation
branch
from
53dbc27 to
2d53972
Compare
treysp
force-pushed
the
trey/comment-truncation
branch
from
2d53972 to
a622e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some engines error if comments are longer than a maximum length. With this PR they will be automatically truncated to the engine's max.
Some engines, like Spark and Trino, have modular compute, metadata, and storage layers. The max comment length may differ across choices of metadata layer, such as Hive (max 4000 chars) or Iceberg (no max). For modular engines, we handle truncation in the Hive mixin rather than the engine adapter itself.