fix: warn instead of error single catalog multiple catalogs#2251
Merged
fix: warn instead of error single catalog multiple catalogs#2251
Conversation
tobymao
approved these changes
Mar 12, 2024
eakmanrq
force-pushed
the
eakmanrq/warn_instead_of_error_single_catalog
branch
from
4e3e261 to
000b1cd
Compare
eakmanrq
force-pushed
the
eakmanrq/warn_instead_of_error_single_catalog
branch
from
000b1cd to
fb6ff31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR if we detected a single catalog engine (like Postgres) referred to another catalog then it would error. This is likely excessive since the single catalog would error on it's own anyways and it can potentially raise errors when they are needed. Therefore this PR switches this to log a warning instead.