Conversation
tobymao
force-pushed
the
toby/lineage_perf
branch
from
6ba892d to
1d277d5
Compare
vchan
approved these changes
Mar 21, 2024
Contributor
vchan
left a comment
vchan
left a comment
There was a problem hiding this comment.
Should we trim selects here as well? https://github.com/TobikoData/sqlmesh/blob/main/web/server/api/endpoints/lineage.py#L56
Contributor
Author
no, we shouldn't because you use the output to generate a UI and we want those to look clean. but this breaks some tests so i'll need some time to fix it and test |
tobymao
force-pushed
the
toby/lineage_perf
branch
5 times, most recently
from
d94a220 to
abeda2a
Compare
vchan
approved these changes
Apr 9, 2024
georgesittas
approved these changes
Apr 9, 2024
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Looks good, only some questions FMI.
tobymao
force-pushed
the
toby/lineage_perf
branch
from
abeda2a to
37907d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should significantly increase the perf of lineage, will require sqlglot 23.1