Fix!: expand snowflake VIEW column comments and make comment default true#2369
Merged
Fix!: expand snowflake VIEW column comments and make comment default true#2369
Conversation
treysp
changed the title
treysp
changed the title
treysp
changed the title
eakmanrq
approved these changes
Mar 29, 2024
treysp
force-pushed
the
trey/snowflake-comments
branch
from
ae2eb4e to
9919dc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's documentation does not describe or demonstrate a way to alter/add column comments to VIEWs after creation, but
ALTER VIEW ... ALTER COLUMN ...command does this.This PR:
CommentCreationView.IN_SCHEMA_DEF_NO_COLUMN_COMMANDenum value because it was only used by snowflakeTrueby default for Snowflake