Improve error message when the parsing of 'cluster_by' / 'partition_by' fields fails in the dbt loader#2548
Merged
izeigerman merged 1 commit intomainfrom May 1, 2024
Conversation
…y' fields fails in the dbt loader
georgesittas
approved these changes
May 1, 2024
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
LGTM - just a suggestion
Comment on lines
+356
to
+360
| for c in self.cluster_by: | ||
| try: | ||
| clustered_by.append(d.parse_one(c, dialect=dialect).name) | ||
| except SqlglotError as e: | ||
| raise ConfigError(f"Failed to parse cluster_by field '{c}': {e}") from e |
Contributor
There was a problem hiding this comment.
Small QOL - should we aggregate these errors so they're all reported at once after the loop instead of 1 by 1?
Contributor
Author
There was a problem hiding this comment.
Why? It seems like our general strategy has been failing fast
Contributor
There was a problem hiding this comment.
Yeah, that makes sense - I don't feel strongly about this, so feel free to ignore.
My rationale was that I generally prefer seeing all errors at once vs triggering another load of the project to find that another cluster key failed to parse. These would be picked up quickly, so in the literal sense it'd still be fast.
tobymao
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the messages more specific about which field caused the failure.