Fix: Model kind change should not be categorized as forward-only#2551
Merged
izeigerman merged 2 commits intomainfrom May 2, 2024
Merged
Conversation
… be categorized as forward-only
tobymao
reviewed
May 1, 2024
izeigerman
changed the title
izeigerman
force-pushed
the
fix-forward-only-when-changing-from-non-materialized
branch
from
e7edea4 to
072618e
Compare
tobymao
approved these changes
May 2, 2024
izeigerman
deleted the
fix-forward-only-when-changing-from-non-materialized
branch
izeigerman
added a commit
that referenced
this pull request
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix when transitioning from a non-materialized kind like
VIEWto a materialized incremental kind for which theforward_onlyflag is set, SQLMesh would categorized change asFORWARD_ONLYand try to reuse the existing physical table which is actually a view which can't be reused.