Conversation
tobymao
reviewed
Aug 31, 2024
tests/web/conftest.py
Outdated
| from __future__ import annotations | ||
|
|
||
| from pathlib import Path | ||
| import typing as t |
Contributor
There was a problem hiding this comment.
we don’t need types in tests
tobymao
reviewed
Aug 31, 2024
tests/web/conftest.py
Outdated
|
|
||
| @pytest.fixture | ||
| def project_tmp_path(tmp_path: Path) -> Path: | ||
| def project_tmp_path(tmp_path: Path) -> t.Generator[Path, None, None]: |
Contributor
There was a problem hiding this comment.
this can just be like iterator right? or just remove the types
Contributor
Author
There was a problem hiding this comment.
I'll remove the types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix flaky web/UI lineage tests (when run in parallel) by reseting FastAPI app dependency overrides in between tests and creating a new TestClient per test.