model magic for seeds fixes #225 #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
approved these changes
Feb 8, 2023
izeigerman
reviewed
Feb 8, 2023
sqlmesh/core/context.py
Outdated
Member
There was a problem hiding this comment.
Shouldn't this logic be a part of the render_query overridden in SeedModel? I'd rather avoid ifs like this.
Contributor
Author
There was a problem hiding this comment.
no, it's a different purpose. render_query is used for CTAS and other things. the context render is purely for the user
tobymao
force-pushed
the
toby/magic_seeds
branch
2 times, most recently
from
ce7332b to
479c0aa
Compare
izeigerman
reviewed
Feb 8, 2023
tobymao
force-pushed
the
toby/magic_seeds
branch
from
479c0aa to
d14387a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.