Fix: Add adapters for commands that are not using the snapshot evaluator#3531
Fix: Add adapters for commands that are not using the snapshot evaluator#3531themisvaltinos merged 6 commits intomainfrom
Conversation
|
No existing tests picked up this regression, are you able to add a test? |
Yes because these commands wouldnt work only for models which had the gateway specified property. I will think of tests to add as well |
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
5c501f2 to
01969a8
Compare
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
d02ffcf to
a31a67d
Compare
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
95a012c to
07d048c
Compare
| if config.model_defaults.dialect != ctx.dialect: | ||
| config.model_defaults = config.model_defaults.copy(update={"dialect": ctx.dialect}) | ||
|
|
||
| # To enable parallelism in integration tests |
There was a problem hiding this comment.
Why does this impact parallelism?
There was a problem hiding this comment.
To isolate the connections per test because otherwise they will encounter concurrency issues, as they will end up using the same connections. Since all the engine adapters are created upfront and this particular file's tests are using for the context the same config: https://github.com/TobikoData/sqlmesh/blob/main/tests/core/engine_adapter/integration/config.yaml
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
07d048c to
0c258c3
Compare
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
0c258c3 to
e9bc257
Compare
4 participants
This fixes an omission on the latest multi-engine feature, to create the engine adapters in cases when they're not generated in the snapshot_evaluator property, ie for the commands
render,table_diffandcreate_test